Change in vdsm[master]: vm: remove unused reqsize and needExtend

fsimonce at redhat.com fsimonce at redhat.com
Mon Oct 15 07:46:43 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: vm: remove unused reqsize and needExtend
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/vm.py
Line 744:             self.log.debug('%s/%s (%s): apparentsize %s req %s', d.domainID,
Line 745:                            d.volumeID, d.name, d.apparentsize / constants.MEGAB,
Line 746:                            newsize) #in MiB
Line 747: 
Line 748:             volID = d.volumeID
ok, I didn't notice it because the live storage migration patch is going to change this method anyway. Fixing it.
Line 749:             break
Line 750: 
Line 751:     def _refreshLV(self, domainID, poolID, imageID, volumeID):
Line 752:         """ Stop vm before refreshing LV. """


--
To view, visit http://gerrit.ovirt.org/8381
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2387963eebb1b97be0d32396f14817ab7219732f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list