Change in vdsm[master]: storage: failure to reconnect to authenticated iSCSI LUNs

abaron at redhat.com abaron at redhat.com
Sun Oct 14 19:13:47 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: storage: failure to reconnect to authenticated iSCSI LUNs
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(2 inline comments)

Maybe a subsequent patch to straighten out the terminology used in the functions to make the code more legible?

....................................................
File vdsm/storage/iscsi.py
Line 85:     targetname = os.path.join(iscsi_session, "targetname")
Line 86:     iface = os.path.join(iscsi_session, "ifacename")
Line 87:     tpgt = os.path.join(iscsi_session, "tpgt")
Line 88: 
Line 89:     user = os.path.join(iscsi_session, "username")
this should probably be userFile to avoid the confusion (same for passwdFile etc)
Line 90:     passwd = os.path.join(iscsi_session, "password")
Line 91: 
Line 92:     paddr = os.path.join(iscsi_connection, "persistent_address")
Line 93:     pport = os.path.join(iscsi_connection, "persistent_port")


....................................................
File vdsm/storage/multipath.py
Line 315:                     # Note that credentials must be sent back in order for
Line 316:                     # the engine to tell vdsm how to reconnect later
Line 317:                     if sess.credentials:
Line 318:                         cred = sess.credentials
Line 319:                         sessionInfo['user'] = cred.username
why not standardize everything on either 'user' or 'username'?
Line 320:                         sessionInfo['password'] = cred.password
Line 321: 
Line 322:                     knownSessions[sessionID] = sessionInfo
Line 323:                 devInfo["connections"].append(knownSessions[sessionID])


--
To view, visit http://gerrit.ovirt.org/8523
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id717ee5b45adede4f9094f842ead06b0ba91f8b2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list