Change in vdsm[master]: vdsm-reg: use M2Crypto instead of pyOpenSSL

danken at redhat.com danken at redhat.com
Sun Oct 14 08:15:05 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: use M2Crypto instead of pyOpenSSL
......................................................................


Patch Set 1: (1 inline comment)

I had bad experience with m2crypto in the past (memory leak, GIL deadlocks) and was pretty happy to remove it.

It may well be that m2crypto is currently no worse than pyOpenSSL, and the limited usage here is not expected to expose the likes of the former troubles.

However, would you elaborate about the "more supported and has superior coverage"?

....................................................
File vdsm_reg/deployUtil.py.in
Line 1550: 
Line 1551:     """
Line 1552:     # import M2Crypto here so
Line 1553:     # it be done only at vdsm-reg
Line 1554:     # which depends on pyOpenSSL
comment rot.
Line 1555:     from M2Crypto import SSL, X509
Line 1556: 
Line 1557:     # openssl verify callback does not
Line 1558:     # accept context, so we collect the chain


--
To view, visit http://gerrit.ovirt.org/8522
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id16479e61777dceffaf3c0253ef2b2954e5588a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>


More information about the vdsm-patches mailing list