Change in vdsm[master]: storage functional test with multiple storage domains and im...

Ryan Harper ryanh at us.ibm.com
Fri Oct 12 16:21:25 UTC 2012


Ryan Harper has posted comments on this change.

Change subject: storage functional test with multiple storage domains and images
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File tests/functional/xmlrpcTests.py
Line 246:         for poolid, pool in storagePools.iteritems():
Line 247:             r = self.s.createStoragePool(
Line 248:                     poolType, poolid, pool['name'], pool['master_uuid'],
Line 249:                     layout[poolid].keys(), pool['master_ver'])
Line 250:             self.assertVdsOK(r)
To support the case where the host running the test might already have active storage pools defined, you'll need something like this:

if pool isn't SPM then:
   disable_spm()
   for cp in getConnectedStoragePools():
       disconnectStoragePool(cp)

    connectStoragePool(pool)

enable_spm()
Line 251:             # Connect to pool
Line 252:             r = self.s.connectStoragePool(
Line 253:                     poolid, pool['host'], 'scsikey', pool['master_uuid'],
Line 254:                     pool['master_ver'])


--
To view, visit http://gerrit.ovirt.org/8182
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8287046046460f399f180d19e0717a91419297f8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list