Change in vdsm[master]: hsm: use misc.parseBool instead of ad-hoc bool convertion

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Oct 11 08:17:32 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: hsm: use misc.parseBool instead of ad-hoc bool convertion
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1704:            raise se.VolumeGroupSizeError("VG size must be more than %s MiB" % str(MINIMALVGSIZE / constants.MEGAB))
Line 1705: 
Line 1706:         lvm.createVG(vgname, devices, blockSD.STORAGE_UNREADY_DOMAIN_TAG,
Line 1707:                      metadataSize=blockSD.VG_METADATASIZE,
Line 1708:                      force=misc.parseBool(force))
How about using utils.tobool here instead of misc.parseBool. Its behaviour fulfils what we want, I think.
Line 1709: 
Line 1710:         return dict(uuid=lvm.getVG(vgname).uuid)
Line 1711: 
Line 1712: 


--
To view, visit http://gerrit.ovirt.org/8482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ce0ec34d10380c8e1e8bd94e17ef436deb28579
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list