Change in vdsm[master]: Remove duplicate implementation of tobool

zhshzhou at linux.vnet.ibm.com zhshzhou at linux.vnet.ibm.com
Thu Oct 11 05:43:40 UTC 2012


Zhou Zheng Sheng has posted comments on this change.

Change subject: Remove duplicate implementation of tobool
......................................................................


Patch Set 2:

As far as I know there is no obvious way to suppress the warning. I thin keep hooking.py in the PEP8WHITELIST is good, add a redundant "tobool" line is OK.
 
In vdsm/storage/misc.py there is a parseBool function, I think it's the same as utils.tobool. How about remove parseBool to use tobool?

--
To view, visit http://gerrit.ovirt.org/8446
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0d382dabc9df68139070e8ac10f84ba1ca3774b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list