Change in vdsm[master]: start ksm and ksmtuned when vdsm starts

shuming at linux.vnet.ibm.com shuming at linux.vnet.ibm.com
Thu Oct 11 02:12:00 UTC 2012


Shu Ming has posted comments on this change.

Change subject: start ksm and ksmtuned when vdsm starts
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

Got two comments in line.   For Dan, does vdsmd.init or vdsmd.server start ksmtuned/ksm service now?

....................................................
File vdsm/ksm.py
Line 65:         except:
Line 66:             self._cif.log.error("Error monitoring KSM", exc_info=True)
Line 67: 
Line 68:     def readState(self):
Line 69:         return ksm_running(), npages()
It seems that ksm_running() was not defined after running() was removed.
Line 70: 
Line 71:     def adjust(self):
Line 72:         """adjust ksm state according to configuration and current memory stress
Line 73:         return whether ksm is running"""


Line 92:         return npages
Line 93:     except:
Line 94:         return 0
Line 95: 
Line 96: def ksm_start():
Not sure why you removed the running() check here.  In some linux variant node, the service may already be started by administrators. restarting them may cause problem.
Line 97:     utils.execCmd([constants.EXT_SERVICE, 'ksmtuned', 'start'], sudo=True)
Line 98:     utils.execCmd([constants.EXT_SERVICE, 'ksm', 'start'], sudo=True)
Line 99: 
Line 100: def tune(params):


--
To view, visit http://gerrit.ovirt.org/8357
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50087aae112069b2a427fca12168aff975b443e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list