Change in vdsm[master]: start ksm and ksmtuned when vdsm starts

lhornyak at redhat.com lhornyak at redhat.com
Wed Oct 10 12:16:16 UTC 2012


Laszlo Hornyak has posted comments on this change.

Change subject: start ksm and ksmtuned when vdsm starts
......................................................................


Patch Set 2: (4 inline comments)

....................................................
File vdsm/ksm.py
Line 85
Line 86
Line 87
Line 88
Line 89
so as we discussed, tests were deleted


Line 92:         return npages
Line 93:     except:
Line 94:         return 0
Line 95: 
Line 96: def ksm_start():
and it was renamed to ksm_start since the start() already caused confusion (this is not a method of the thread class)
Line 97:     utils.execCmd([constants.EXT_SERVICE, 'ksmtuned', 'start'], sudo=True)
Line 98:     utils.execCmd([constants.EXT_SERVICE, 'ksm', 'start'], sudo=True)
Line 99: 
Line 100: def tune(params):


Line 94
Line 95
Line 96
Line 97
Line 98
no more checking if the service is up or not


Line 98
Line 99
Line 100
Line 101
Line 102
this method is gone since no longer want to stop the services


--
To view, visit http://gerrit.ovirt.org/8357
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50087aae112069b2a427fca12168aff975b443e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>


More information about the vdsm-patches mailing list