Change in vdsm[master]: bootstrap: allow customize bridge name for standard sequence
danken at redhat.com
danken at redhat.com
Wed Oct 10 00:52:28 UTC 2012
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: allow customize bridge name for standard sequence
......................................................................
Patch Set 2: Looks good to me, approved
(2 inline comments)
very minor and general comments.
....................................................
File vdsm_reg/deployUtil.py.in
Line 926: "_getRHELBridgeParams Found bonding: %s."
Line 927: "This network configuration is not"
Line 928: "supported! Please configure %s bridge"
Line 929: "manually and re-install."
Line 930: ) % (str(nic), bridgeName)
if you're using %s, you can drop the str() calls.
Line 931: )
Line 932: nic = None
Line 933: except:
Line 934: logging.error("_getRHELBridgeParams Failed to test for VLAN data")
Line 1033: (
Line 1034: "makeBridge Failed to add %s bridge out=%s\n"
Line 1035: "err=%s\n"
Line 1036: "ret=%s"
Line 1037: ) % (bridgeName, out, str(err), str(ret))
I know it is not your bug, but if something goes wrong in _logExec, ret and err would be undefined, and we would loose the exception information.
I do not think you should fix everything in one patch - to the contrary.
Line 1038: )
Line 1039:
Line 1040: #Save current config by removing the undo files:
Line 1041: try:
--
To view, visit http://gerrit.ovirt.org/8388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c178de55e14ecdcff92270df489dc1415ef26f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
More information about the vdsm-patches
mailing list