Change in vdsm[master]: Make nics, vlan and bonding dhcp ifup to be asynchronous.

danken at redhat.com danken at redhat.com
Tue Oct 9 18:02:15 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Make nics, vlan and bonding dhcp ifup to be asynchronous.
......................................................................


Patch Set 7: Looks good to me, approved

(1 inline comment)

thanks!

....................................................
File vdsm/configNetwork.py
Line 963: 
Line 964:     # NICs must be activated in the same order of boot time
Line 965:     # to expose the correct MAC address.
Line 966:     for nic in nicSort(nics):
Line 967:         ifup(nic, options.get('bootproto') == 'dhcp' and not blockingDhcp)
doh
Line 968: 
Line 969:     # Now we can ifup VLAN interface, because bond and nic already up
Line 970:     if vlan:
Line 971:         ifup(iface, vlanBootproto == 'dhcp' and not blockingDhcp)


--
To view, visit http://gerrit.ovirt.org/8098
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80f5bbfe5ba4dfcf8f7f29c21a60b0cc2e129cb0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list