Change in vdsm[master]: add and use hypervisor autodetection in bootstrap.

fromani at gmail.com fromani at gmail.com
Thu Oct 4 05:09:38 UTC 2012


Francesco Romani has posted comments on this change.

Change subject: add and use hypervisor autodetection in bootstrap.
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 1328: def cpuHypervisorID():
Line 1329:     # we cannot (yet) use _cpuid because of the different
Line 1330:     # unpack format.
Line 1331:     HYPERVISOR_CPUID_LEAF = 0x40000000
Line 1332:     with open('/dev/cpu/0/cpuid') as f:
You're right, for example in debian it (used to) is configured as a module.

I agree a workaround for those situations has to be provided.

However I think this fix is definitively out of scope for this patch, because deployUtil already depends on the avaibility of the file (see the whole virtEnabledInCpuAndBios workhorse function) and this change doesn't worse the situation in any way.

On a sidenote, the ovirt wiki may be out of date also, because it clearly states
"Currently, Vdsm requires Red Hat Enterprise Linux 6.2 or Fedora 16 to run properly. " (http://wiki.ovirt.org/wiki/Vdsm)

After having said all of the above, I don't have any idea yet about how to fix the cpuid availability problem :)
Line 1333:         f.seek(HYPERVISOR_CPUID_LEAF)
Line 1334:         c = struct.unpack('I12s', f.read(16))
Line 1335:         return c[1].strip('\x00')
Line 1336: 


--
To view, visit http://gerrit.ovirt.org/7657
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79f4ab08b838bd75af5d4c26f98923fca0d65d8e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at gmail.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at gmail.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list