Change in vdsm[master]: image: copying a template is always allowed

fsimonce at redhat.com fsimonce at redhat.com
Tue Oct 9 11:33:42 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: image: copying a template is always allowed
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 1316:                     self.log.error("Cannot move image %s to domain %s "
Line 1317:                             "because the template %s is missing on the "
Line 1318:                             "destination", imgUUID, dstDom.sdUUID, tName)
Line 1319:                     raise se.ImageDoesNotExistInSD(imgUUID, dstDom.sdUUID)
Line 1320:                 elif (safeToMove and imgUUID == tImgs[0]
I agree on removing this validation, we shouldn't miss this opportunity to remove an extra validation (that we hate so much) which is even preventing us from addressing more use cases.
Line 1321:                                      and not srcDom.isBackup()):
Line 1322:                     raise se.MoveTemplateImageError(imgUUID)
Line 1323: 
Line 1324:                 break


--
To view, visit http://gerrit.ovirt.org/8408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e07d569eec02ac4dcd386a7c576342f640ec242
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list