Change in vdsm[master]: add xmlrpcTests for cpu pinning
zhshzhou at linux.vnet.ibm.com
zhshzhou at linux.vnet.ibm.com
Tue Oct 9 03:35:30 UTC 2012
Zhou Zheng Sheng has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File tests/functional/xmlrpcTests.py
Line 202: self.retryAssert(assertVMAndGuestUp, 65, 1)
Line 203: finally:
Line 204: destroyResult = self.s.destroy(VMID)
Line 205:
Line 206: self.assertVdsOK(destroyResult)
You may notice there is duplicate code for starting a test VM, so I extract a method for this. Could you have a look at gerrit.ovirt.org/#/c/8183/ ? I add a method named "_runVMKernelBoot" in this file. Would you give me some comments on that new method? If you think it's useful, I can split it from my 8183 and submit a separate patch.
--
To view, visit http://gerrit.ovirt.org/8412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia865f0d5eb4c9aabff6cef57b088c55df73a309e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
More information about the vdsm-patches
mailing list