Change in vdsm[master]: vdsm-reg: use web server CA extracted from SSL handshake

danken at redhat.com danken at redhat.com
Sun Oct 7 21:09:46 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm-reg: use web server CA extracted from SSL handshake
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm_reg/deployUtil.py.in
Line 38: import glob
Line 39: import imp
Line 40: from optparse import OptionParser
Line 41: import platform
Line 42: import  OpenSSL
oh dear, double space.

but more worrying is what Doron has raised: are we sure it is available whenever deployUtil is imported?
Line 43: 
Line 44: try:
Line 45:     from ovirtnode import ovirtfunctions
Line 46: except ImportError:


Line 1578: 
Line 1579:     """
Line 1580:     try:
Line 1581:         chain = getChainFromSSL((IP, port))
Line 1582:         cert = chain[-1]
frankly, I'm not happy about the "cert" name, since we already have "crt" for for its file object.
Line 1583:         _, _, engineWebCACert = certPaths('')
Line 1584:         dirName = os.path.dirname(engineWebCACert)
Line 1585:         if not os.path.exists(dirName):
Line 1586:             os.makedirs(dirName)


--
To view, visit http://gerrit.ovirt.org/8386
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8727a167de19ac66712309868654ae00c9bf4d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>


More information about the vdsm-patches mailing list