Change in vdsm[master]: Change source of CPU sockets/cores to libvirt capabilities

danken at redhat.com danken at redhat.com
Sat Oct 6 21:16:53 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Change source of CPU sockets/cores to libvirt capabilities
......................................................................


Change source of CPU sockets/cores to libvirt capabilities

Bug-Url: http://bugzilla.redhat.com/833425

/proc/cpuinfo is not enough to provide full CPU
sockets/cores/threads information in some systems,
e.g. multi NUMA AMD Magny-Cours processors. To bypass
different/unusual architectures and avoid duplication
of code between vdsm and libvirt, this patch changes
the source of CPU topology from /proc/cpuinfo to
libvirt API.

Since libvirt ignores funky topologies [1] with
assimetric number of sockets per numa node and
cores per socket, this patch assumes that all
numa nodes has the same number of sockets and
all sockets has the same number of cores.

Merged with Laszlo's changes in http://gerrit.ovirt.org/8302

[1] - http://libvirt.org/git/?p=libvirt.git;a=commit;h=ac9dd4a676f21b5e3ca6dbe0526f2a6709072beb

Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Signed-off-by: Amador Pahim <apahim at redhat.com>
---
M tests/Makefile.am
M tests/capsTests.py
A tests/caps_libvirt.out
M vdsm.spec.in
M vdsm/caps.py
M vdsm/clientIF.py
6 files changed, 194 insertions(+), 17 deletions(-)

Approvals:
  Amador Pahim: Verified
  Dan Kenigsberg: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5481
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1619e3d9e042bc801c988f099d3b84922f4e03d3
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list