Change in vdsm[master]: setup: move the the certificate generation

fsimonce at redhat.com fsimonce at redhat.com
Fri Oct 5 08:29:25 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: setup: move the the certificate generation
......................................................................


Patch Set 1: (1 inline comment)

> 1. If we run on ovirt-node, shouldn't we persist?

Probably, but it doesn't belong here. It's ovirt-node specific, you could either reuse this script at the end of the bootstrap (+persist) before starting the vdsm service, or eventually start the vdsm service and persist the certificates after.

> 2. I would have created all the files in temporary folder, and if all the process succeeded move to final destination.

Ok.

....................................................
File vdsm/vdsm-gencerts.sh.in
Line 115:     /sbin/restorecon "$__vdsm_gencerts_crt"
Line 116:     /bin/rm -f "$__vdsm_gencerts_template"
Line 117: }
Line 118: 
Line 119: if [ "$1" != "--bash-import" ]; then
Done
Line 120:     vdsm_create_key
Line 121:     vdsm_create_ca
Line 122:     vdsm_create_cert


--
To view, visit http://gerrit.ovirt.org/8368
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list