Change in vdsm[master]: Add support for KVM on IBM POWER processor (ppc64)

danken at redhat.com danken at redhat.com
Fri Oct 5 07:19:05 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Add support for KVM on IBM POWER processor (ppc64)
......................................................................


Patch Set 5: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm_reg/deployUtil.py.in
Line 326:     return fReturn
Line 327: 
Line 328: def getMachineUUID():
Line 329:     """
Line 330:         This function parses the DMI data for the host's UUID. If not found, returns "None".
what a horrible semantics. but not your fault, obviously.
Line 331:     """
Line 332:     arch = platform.machine()
Line 333:     if arch == 'x86_64':
Line 334:         out, err, ret = _logExec([EX_DMIDECODE, "-s", "system-uuid"])


--
To view, visit http://gerrit.ovirt.org/8094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8767c52488ab8083123d0ec1e789d3857e2358
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list