Change in vdsm[master]: Generalize asynchronous ifupping of network interfaces.

danken at redhat.com danken at redhat.com
Wed Oct 3 13:48:35 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Generalize asynchronous ifupping of network interfaces.
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 969: 
Line 970:     if bridged:
Line 971:         ifup(network,
Line 972:              async=bridgeBootproto == 'dhcp' and
Line 973:              not utils.tobool(options.get('blockingdhcp')))
sorry to be an arse (donkey), but could you slightly indent "not" under bridge?
Line 974: 
Line 975:     # add libvirt network
Line 976:     configWriter.createLibvirtNetwork(network, bridged, iface)
Line 977: 


--
To view, visit http://gerrit.ovirt.org/8097
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If305a9730222deb76aa3c52f0239e3a833a952bd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list