Change in vdsm[master]: Generalize asynchronous ifupping of network interfaces.

danken at redhat.com danken at redhat.com
Wed Oct 3 10:12:23 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Generalize asynchronous ifupping of network interfaces.
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

nit-picking only; I like the idea.

....................................................
File vdsm/configNetwork.py
Line 59:     rc, out, err = execCmd([constants.EXT_IFDOWN, iface], raw=True)
Line 60:     return rc
Line 61: 
Line 62: 
Line 63: def ifup(iface, async = False):
pep8 sheds a tear
Line 64:     "Bring up an interface"
Line 65:     _ifup = lambda netIf: execCmd([constants.EXT_IFUP, netIf], raw=True)
Line 66: 
Line 67:     if async:


Line 967:     if vlan:
Line 968:         ifup(iface)
Line 969: 
Line 970:     if bridged:
Line 971:         ifup(network, bridgeBootproto == 'dhcp' and \
trailing backslash not required. And a named arg would have made it easier for me.
Line 972:                       not utils.tobool(options.get('blockingdhcp')))
Line 973: 
Line 974:     # add libvirt network
Line 975:     configWriter.createLibvirtNetwork(network, bridged, iface)


--
To view, visit http://gerrit.ovirt.org/8097
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If305a9730222deb76aa3c52f0239e3a833a952bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list