Change in vdsm[master]: Added glusterVolumeStatus verb

danken at redhat.com danken at redhat.com
Tue Oct 2 17:44:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added glusterVolumeStatus verb
......................................................................


Patch Set 17: Looks good to me, approved

(1 inline comment)

seems sane to me.

....................................................
File tests/gluster_cli_tests.py
Line 31: import xml.etree.cElementTree as etree
Line 32: 
Line 33: 
Line 34: class GlusterCliTests(TestCaseBase):
Line 35:     maxDiff = None
I was not aware of unittest.TestCase.maxDiff. Sorry.
Line 36: 
Line 37:     def setUp(self):
Line 38:         if not "gcli" in globals().keys():
Line 39:             raise SkipTest("vdsm-gluster not found")


--
To view, visit http://gerrit.ovirt.org/6374
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8769c2da299a598ed7500c4780a3329972f4a8ac
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list