Change in vdsm[master]: supervdsmServer is down after failed operation

smizrahi at redhat.com smizrahi at redhat.com
Tue Oct 2 14:33:55 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: supervdsmServer is down after failed operation
......................................................................


Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/supervdsm.py
Line 54: 
Line 55: 
Line 56: class ProxyCaller(object):
Line 57: 
Line 58:     _proxyLock = threading.Lock()
Avoid static locks. Pass the lock from the svdsm instance in the ctor.
Line 59: 
Line 60:     def __init__(self, supervdsmProxy, funcName):
Line 61:         self._funcName = funcName
Line 62:         self._supervdsmProxy = supervdsmProxy


--
To view, visit http://gerrit.ovirt.org/7901
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idad4a622b82259b777851d1b0c1b37ec8da2b01e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>


More information about the vdsm-patches mailing list