Change in vdsm[master]: proposed cleanup for Amador's patch

danken at redhat.com danken at redhat.com
Tue Oct 2 14:09:44 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: proposed cleanup for Amador's patch
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

please squash into one happy patch that is agreed to by everybody.

....................................................
File vdsm/caps.py
Line 117:                         'core': int(cpu.getElementsByTagName('topology')[0].
Line 118:                                                       getAttribute('cores')),
Line 119:                         'thread': int(cpu.getElementsByTagName('topology')[0].
Line 120:                                                       getAttribute('threads'))}
Line 121:         except BaseException, e:
do not use BaseException. Why would you want to handle ctrl-c?
In this specific case, adding exc_info=True. would provide better information.
Line 122:             logging.error('error calculating the topology data: %s', e)
Line 123:             # During tests/make rpm, libvirt may not be available/configured.
Line 124:             # Hack arround it.
Line 125:             topology = {'numa': 1,


--
To view, visit http://gerrit.ovirt.org/8302
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I677f13e9a511bb1652dbbb84fe672714215e5aa8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>


More information about the vdsm-patches mailing list