Change in vdsm[master]: BZ#781975 VM creation concurrency limit

peet at redhat.com peet at redhat.com
Tue Oct 2 10:03:26 UTC 2012


Peter V. Saveliev has uploaded a new change for review.

Change subject: BZ#781975 VM creation concurrency limit
......................................................................

BZ#781975 VM creation concurrency limit

Since libvirt now does not support concurrent VM creation,
simultaneous requests lead to the situation when a user
should wait all VMs to be created before he sees any progress
in the UI. Tho just for now it is more reasonable to limit
parallel creation (4 threads does the stuff slightly faster
than 1, and a user will see the progress in UI). As libvirt
will support more fine-grained lock in its driver, we can
return to caps.CpuInfo().cores() usage.

Change-Id: I527c1f5201646f7f912d976b59355f70b8ca20eb
Signed-off-by: Peter V. Saveliev <peet at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=781975
---
M vdsm/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/8295/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index 742e9fd..c5507e9 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -260,7 +260,8 @@
     its behaviour.
     """
     log = logging.getLogger("vm.Vm")
-    _ongoingCreations = threading.BoundedSemaphore(caps.CpuInfo().cores())
+    # limit threads number until the libvirt lock will be fixed
+    _ongoingCreations = threading.BoundedSemaphore(4)
     MigrationSourceThreadClass = MigrationSourceThread
 
     def __init__(self, cif, params):


--
To view, visit http://gerrit.ovirt.org/8295
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I527c1f5201646f7f912d976b59355f70b8ca20eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <peet at redhat.com>


More information about the vdsm-patches mailing list