Change in vdsm[master]: Add support for KVM on IBM POWER processor (ppc64)
Ryan Harper
ryanh at us.ibm.com
Mon Oct 1 20:53:04 UTC 2012
Ryan Harper has posted comments on this change.
Change subject: Add support for KVM on IBM POWER processor (ppc64)
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 327: def getMachineUUID():
Line 328: """
Line 329: This function parses the DMI data for the host's UUID. If not found, returns "None".
Line 330: """
Line 331: arch = getPlatformArch()
One last nit. Unless we have another caller for getPlatformArch() I suggest just doing:
arch = platform.machine()
and dropping the other function altogether.
Line 332: if arch == 'x86_64':
Line 333: out, err, ret = _logExec([EX_DMIDECODE, "-s", "system-uuid"])
Line 334: out = '\n'.join( line for line in out.splitlines()
Line 335: if not line.startswith('#') )
--
To view, visit http://gerrit.ovirt.org/8094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8767c52488ab8083123d0ec1e789d3857e2358
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Pradipta Banerjee <bpradip at in.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
More information about the vdsm-patches
mailing list