Change in vdsm[master]: Fix duplicate emulated machines returned

Ryan Harper ryanh at us.ibm.com
Mon Oct 1 20:30:36 UTC 2012


Ryan Harper has posted comments on this change.

Change subject: Fix duplicate emulated machines returned
......................................................................


Patch Set 1: I would prefer that you didn't submit this

While I like removing duplicate information, it's not clear to me what vdsm cares about here.

if you run virsh capabilities (which is what the call is doing), you'll see that for each *emulator* type it is enumerating the machine types the emulator supports.

Some systems may have more than just qemu-kvm emulator.

If vdsm wanted to support multiple emulators, I think it would make sense to enumerate the machine types *per emulator*.

If we only care about qemu-kvm (and I think we do) then I think the patch is good enough.  If we want to be more explicit, then the emulatedMachines field ought to be a list of dictionaries, one for each emulator and the machine types each emulator supports.

Thoughts?

--
To view, visit http://gerrit.ovirt.org/8208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list