Change in vdsm[master]: Bug 852956 - 3.1 - prepareForShutdown is not called when con...

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Mon Oct 1 11:46:20 UTC 2012


Michal Skrivanek has uploaded a new change for review.

Change subject: Bug 852956 - 3.1 - prepareForShutdown is not called when connection to libvirt is broken with event: libvirtError: internal error client socket is closed add few more error codes from libvirt's virsh code
......................................................................

Bug 852956 - 3.1 - prepareForShutdown is not called when connection to libvirt is broken with event: libvirtError: internal error client socket is closed
add few more error codes from libvirt's virsh code

Change-Id: Ic1d9a2cd9bfd7da9118d643d0e50106e5e759590
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=852956
Signed-off-by: Michal Skrivanek <michal.skrivanek at redhat.com>
---
M vdsm/libvirtconnection.py
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/8283/1

diff --git a/vdsm/libvirtconnection.py b/vdsm/libvirtconnection.py
index e525996..01c6db1 100644
--- a/vdsm/libvirtconnection.py
+++ b/vdsm/libvirtconnection.py
@@ -87,7 +87,10 @@
                             setattr(ret, name, wrapMethod(method))
                 return ret
             except libvirt.libvirtError, e:
-                if (e.get_error_domain() in (libvirt.VIR_FROM_REMOTE, libvirt.VIR_FROM_RPC)
+                if (e.get_error_domain() in (libvirt.VIR_FROM_REMOTE, 
+                                             libvirt.VIR_FROM_RPC,
+                                             libvirt.VIR_ERR_NO_CONNECT,
+                                             libvirt.VIR_ERR_INVALID_CONN)
                     and e.get_error_code() == libvirt.VIR_ERR_SYSTEM_ERROR):
                     cif.log.error('connection to libvirt broken. '
                                   'taking vdsm down.')


--
To view, visit http://gerrit.ovirt.org/8283
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1d9a2cd9bfd7da9118d643d0e50106e5e759590
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <michal.skrivanek at redhat.com>


More information about the vdsm-patches mailing list