Change in vdsm[master]: upgrade: skip volume lease for faulty metadata offsets

fsimonce at redhat.com fsimonce at redhat.com
Fri Nov 30 18:59:22 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: upgrade: skip volume lease for faulty metadata offsets
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 169:                 # the domain upgrade). Few vdsm releases (4.9 prior 496c0c3)
Line 170:                 # generated metadata offsets higher than 2048 - 100 - 1 that
Line 171:                 # would not permit sanlock to store the volume resource in
Line 172:                 # the leases LV.
Line 173:                 if e.errno == errno.ENOSPC and metaOffset > BLKVOL_MAX_OFFSET:
We could also try to tag the storage domain in some way to recognize it (faster/easier) later.
Line 174:                     log.error("The volume lease for %s has not been "
Line 175:                               "initialized due bz882276, metadata offset "
Line 176:                               "too high: %s", volUUID, metaOffset)
Line 177:                 else:


--
To view, visit http://gerrit.ovirt.org/9600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic84108d4fbe0dfee9fe1d57c802f99dd937cd8ec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list