Change in vdsm[master]: vdsm: use default libvirt event handler impl

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Thu Nov 29 16:48:33 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: vdsm: use default libvirt event handler impl
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 63:                   "Shutdown",
Line 64:                   "PM-Suspended")
Line 65: 
Line 66: 
Line 67: def event_to_string(event):
yes, CamelCase. Dan has mentioned.
Line 68:     return _EVENT_STRINGS[event]
Line 69: 
Line 70: 
Line 71: class VmStatsThread(utils.AdvancedStatsThread):


--
To view, visit http://gerrit.ovirt.org/5015
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I735d6b1f856b5a5b216d2dddf629c5ec80e8b7e7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list