Change in vdsm[master]: [WIP] netwiring: [3/3] Add API definitions.

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Thu Nov 29 15:19:10 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: [WIP] netwiring: [3/3] Add API definitions.
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 1540:             return {'status':
Line 1541:                     {'code': errCode['updateDevice']['status']['code'],
Line 1542:                      'message': 'Missing net device'}}
Line 1543: 
Line 1544:         network = dev['network']
netDev?
Line 1545: 
Line 1546:         # Prepare the updateDevice xml
Line 1547:         netelem = xml.dom.minidom.Element(params['type'])
Line 1548:         netelem.setAttribute('type', 'bridge')


Line 1546:         # Prepare the updateDevice xml
Line 1547:         netelem = xml.dom.minidom.Element(params['type'])
Line 1548:         netelem.setAttribute('type', 'bridge')
Line 1549:         mac = xml.dom.minidom.Element('mac')
Line 1550:         mac.setAttribute('address', dev['macAddr'])
netDev?
Line 1551:         netelem.appendChild(mac)
Line 1552:         model = xml.dom.minidom.Element('model')
Line 1553:         model.setAttribute('type', dev['nicModel'])
Line 1554:         netelem.appendChild(model)


Line 1549:         mac = xml.dom.minidom.Element('mac')
Line 1550:         mac.setAttribute('address', dev['macAddr'])
Line 1551:         netelem.appendChild(mac)
Line 1552:         model = xml.dom.minidom.Element('model')
Line 1553:         model.setAttribute('type', dev['nicModel'])
netDev?
Line 1554:         netelem.appendChild(model)
Line 1555: 
Line 1556:         if 'network' not in params:
Line 1557:             # If no network is specified we take the vnic to the dummy bridge


--
To view, visit http://gerrit.ovirt.org/9562
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b9b4f49f80466a83e3e13f1042ac2a8866c6bcd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list