Change in vdsm[master]: forceVMstart: Initial commit

Pablo.Iranzo at redhat.com Pablo.Iranzo at redhat.com
Thu Nov 29 11:58:33 UTC 2012


Pablo Iranzo Gómez has posted comments on this change.

Change subject: forceVMstart: Initial commit
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File contrib/forceVMstart.py
Line 89:         return 0
Line 90: 
Line 91:     def checkRoot(self):
Line 92:         """check if the user running the script is root"""
Line 93:         if os.geteuid() != 0:
Regaring the assert, I'm trying the code on my computer and:

import os
assert(os.geteuid() == 0,'sudo it')

gives:

[iranzo at x201 ~]$ python prueba.py
prueba.py:2: SyntaxWarning: assertion is always true, perhaps remove parentheses?
  assert(os.geteuid() == 0,'sudo it')

¿Is something I'm doing wrong?
Thanks!
Line 94:             print "You must be root to run this script."
Line 95:             sys.exit(2)
Line 96: 
Line 97:     def getIpManagementIP(self):


--
To view, visit http://gerrit.ovirt.org/9473
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a70b31ce0730194880406701316f219c9f92ceb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pablo Iranzo Gómez <Pablo.Iranzo at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list