Change in vdsm[master]: netwiring: [2/3] Add API definitions.
asegurap at redhat.com
asegurap at redhat.com
Thu Nov 29 09:34:56 UTC 2012
Antoni Segura Puimedon has posted comments on this change.
Change subject: netwiring: [2/3] Add API definitions.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 1740: 'libvirt-like format. see '
Line 1741: 'http://libvirt.org/formatdomain.html'
Line 1742: '#elementsCPUTuning'
Line 1743: )),
Line 1744: 'updateVmDevice': (serv.updateVmDevice,
The problem is that all these methods indentations are wrong according to PEP8. I was trying to keep the same style as the others. Maybe you're right and I should just make this change to be pep8 compliant and later fix the other stuff.
Line 1745: ('<vmId> <devicespec>',
Line 1746: 'Update a VM\'s device',
Line 1747: 'devicespec parameters list: r=required, o=optional',
Line 1748: 'r type: interface',
--
To view, visit http://gerrit.ovirt.org/9561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I637b3f584e28afc5ada6496abbb6f61aadb8d64f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list