Change in vdsm[master]: Fix duplicate emulated machines returned

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Nov 29 07:38:52 UTC 2012


Vinzenz Feenstra has posted comments on this change.

Change subject: Fix duplicate emulated machines returned
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/caps.py
Line 21: """Collect host capabilities"""
Line 22: 
Line 23: import os
Line 24: from xml.dom import minidom
Line 25: import xml.etree.ElementTree as ET
Do we really need to import it as ET?
On usage this might be quite confusing. And for a one time use I don't see a point in having a short cut.
Line 26: import logging
Line 27: import time
Line 28: import struct
Line 29: import socket


--
To view, visit http://gerrit.ovirt.org/8208
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e28688bf09b5bc413afffe9cc1501d4247d67e0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list