Change in vdsm[master]: Allow to remove NIC if it not in use

ilvovsky at redhat.com ilvovsky at redhat.com
Wed Nov 28 11:40:03 UTC 2012


Igor Lvovsky has posted comments on this change.

Change subject: Allow to remove NIC if it not in use
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1061:     for nic in nics:
Line 1062:         if not nicOtherUsers(network, vlan, bonding, nic):
Line 1063:             ifdown(nic)
Line 1064:             configWriter.removeNic(nic)
Line 1065:             ifup(nic)
because of https://bugzilla.redhat.com/show_bug.cgi?id=691484
Line 1066: 
Line 1067: 
Line 1068: def delNetwork(network, vlan=None, bonding=None, nics=None, force=False,
Line 1069:                configWriter=None, implicitBonding=True, **options):


--
To view, visit http://gerrit.ovirt.org/9508
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb8e5fce14fc38c3df9c0b12dc4077726436807e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list