Change in vdsm[master]: upgrade: make sure that the lease files have correct permiss...

danken at redhat.com danken at redhat.com
Tue Nov 27 19:43:25 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: upgrade: make sure that the lease files have correct permission
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 91:     log.debug("Starting conversion for domain %s", domain.sdUUID)
Line 92: 
Line 93:     if domain.getStorageType() in sd.FILE_DOMAIN_TYPES:
Line 94:         log.debug("Setting permissions for domain %s", domain.sdUUID)
Line 95:         domain.setMetadataPermissions()
luckily, on file domains we can do such things before taking an exclusive lock.
Line 96: 
Line 97:     log.debug("Initializing the new cluster lock for domain %s", domain.sdUUID)
Line 98:     newClusterLock = safelease.SANLock(domain.sdUUID, domain.getIdsFilePath(),
Line 99:                                        domain.getLeasesFilePath())


--
To view, visit http://gerrit.ovirt.org/9517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If28c48d2aeedd092ff3b8100dd64cd8ba673e94f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list