Change in vdsm[master]: BZ#870024 - Make sure during upgrade that lease files have ...

fsimonce at redhat.com fsimonce at redhat.com
Tue Nov 27 15:58:25 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: BZ#870024  - Make sure during upgrade that lease files have correct permission
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

Temporary -1 only to have the commit message fixed.

....................................................
Commit Message
Line 3: AuthorDate: 2012-11-27 17:33:22 +0200
Line 4: Commit:     Haim Ateya <hateya at redhat.com>
Line 5: CommitDate: 2012-11-27 17:44:17 +0200
Line 6: 
Line 7: BZ#870024  - Make sure during upgrade that lease files have correct permission
Remove the bz from here. The correct format would be something like:

 upgrade: make sure that the lease files have correct permission
Line 8: 
Line 9: Fix a bug where we tried to initialize sanlock lock before calling
Line 10: the function to set proper permissions.
Line 11: 


Line 7: BZ#870024  - Make sure during upgrade that lease files have correct permission
Line 8: 
Line 9: Fix a bug where we tried to initialize sanlock lock before calling
Line 10: the function to set proper permissions.
Line 11: 
Add the Bug-Url here:

 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=870024
Line 12: Change-Id: If28c48d2aeedd092ff3b8100dd64cd8ba673e94f


....................................................
File vdsm/storage/imageRepository/formatConverter.py
Line 89: def v3DomainConverter(repoPath, hostId, domain, isMsd):
Line 90:     log = logging.getLogger('Storage.v3DomainConverter')
Line 91:     log.debug("Starting conversion for domain %s", domain.sdUUID)
Line 92: 
Line 93:     if domain.getStorageType() in sd.FILE_DOMAIN_TYPES:
As the previous review I'm against this check (I'd prefer setMetadataPermissions to be a noop in BlockStorageDomain). Anyway it's not the time to make this change.
Line 94:         log.debug("Setting permissions for domain %s", domain.sdUUID)
Line 95:         domain.setMetadataPermissions()
Line 96: 
Line 97:     log.debug("Initializing the new cluster lock for domain %s", domain.sdUUID)


--
To view, visit http://gerrit.ovirt.org/9517
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If28c48d2aeedd092ff3b8100dd64cd8ba673e94f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list