Change in vdsm[master]: Fix block volume atomicity creation issue.
abaron at redhat.com
abaron at redhat.com
Tue Nov 27 11:42:39 UTC 2012
Ayal Baron has posted comments on this change.
Change subject: Fix block volume atomicity creation issue.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/storage/blockVolume.py
Line 547: return self.metaoff
Line 548: try:
Line 549: md = _getVolumeTag(self.sdUUID, self.volUUID, TAG_PREFIX_MD)
Line 550: except se.MissingTagOnLogicalVolume:
Line 551: self.log.error("missing offset tag on volume %s/%s",
you've already logged this in _getVolumeTag, why again?
Line 552: self.sdUUID, self.volUUID, exc_info=True)
Line 553: raise se.VolumeMetadataReadError("missing offset tag on volume"
Line 554: "%s/%s" % (self.sdUUID, self.volUUID))
Line 555: else:
Line 640:
Line 641: def _getVolumeTag(sdUUID, volUUID, tagPrefix):
Line 642: tags = lvm.getLV(sdUUID, volUUID).tags
Line 643: if TAG_VOL_UNINIT in tags:
Line 644: log.warning("Reloading uninitialized volume %s/%s", sdUUID, volUUID)
still, it is 'info' at most. nothing wrong here.
Line 645: lvm.invalidateVG(sdUUID)
Line 646: tags = lvm.getLV(sdUUID, volUUID).tags
Line 647: if TAG_VOL_UNINIT in tags:
Line 648: log.error("Found uninitialized volume: %s/%s", sdUUID, volUUID)
--
To view, visit http://gerrit.ovirt.org/9358
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40cd67e563935de663d938cbc1bc9cf152802448
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list