Change in vdsm[master]: tests: Cleanup apiTests exception handling

shaohef at linux.vnet.ibm.com shaohef at linux.vnet.ibm.com
Tue Nov 27 11:14:18 UTC 2012


ShaoHe Feng has posted comments on this change.

Change subject: tests: Cleanup apiTests exception handling
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File tests/apiTests.py
Line 194:         sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
Line 195:         try:
Line 196:             sock.connect((ip, port))
Line 197:             sock.sendall(msg)
Line 198:         except socket.error, e:
if there is something wrong with JsonRpc server,  client will fail to connect it,  but  for testMissingSize,  the test will pass.
Line 199:             raise ProtocolError("Unable to send request: %s", e)
Line 200:         try:
Line 201:             data = sock.recv(JsonRawTest._Size.size)
Line 202:         except socket.error, e:


--
To view, visit http://gerrit.ovirt.org/9499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I818e5e7b8dd0a1abad94deb65e32c1d76225b839
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list