Change in vdsm[master]: [WIP] a more delicate rollback

asegurap at redhat.com asegurap at redhat.com
Tue Nov 27 09:50:42 UTC 2012


Antoni Segura Puimedon has posted comments on this change.

Change subject: [WIP] a more delicate rollback
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

I really like this smarter approach. I only think we should be more careful/more informative with possible errors in the ifdown/ifup part of the process.

....................................................
File vdsm/configNetwork.py
Line 352:             ifdown(dev)
Line 353: 
Line 354:     def _startAtomicDevices(self):
Line 355:         for dev in self._sortModifiedIfcfgs():
Line 356:             ifup(dev)
We should probably keep the return code and if it is not equal to zero log a rollback error.
Line 357: 
Line 358:     @classmethod
Line 359:     def _persistentBackup(cls, filename):
Line 360:         """ Persistently backup ifcfg-* config files """


--
To view, visit http://gerrit.ovirt.org/9506
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If413164a34a1e6f0d7e4ef75ba931e630a26e666
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list