Change in vdsm[master]: Fix MountError exception handling in MountConnection.connect...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Nov 27 05:43:32 UTC 2012


Mark Wu has uploaded a new change for review.

Change subject: Fix MountError exception handling in MountConnection.connect()
......................................................................

Fix MountError exception handling in MountConnection.connect()

The old code swallowed the exception of MountError if dir is removed
successfully. The patches re-raise the exception, which could be
MountError or OSError. In any case, it will stop executing the following
code.

Change-Id: Ic6d9ab419d717345c81fa8e8787e089ccd5a890f
Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
---
M vdsm/storage/storageServer.py
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/03/9503/1

diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 383e04c..6136777 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -202,7 +202,9 @@
                 os.rmdir(self._getLocalPath())
             except OSError as e:
                 if e.errno != errno.ENOENT:
-                    raise
+                    self.log.warn("Error while removing dir %s",
+                                  self._getLocalPath(), exc_info=True)
+            raise
 
         try:
             fileSD.validateDirAccess(self.getMountObj().getRecord().fs_file)


--
To view, visit http://gerrit.ovirt.org/9503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6d9ab419d717345c81fa8e8787e089ccd5a890f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list