Change in vdsm[master]: [WIP] add host-cpu to api

dfediuck at redhat.com dfediuck at redhat.com
Mon Nov 26 15:33:17 UTC 2012


Doron Fediuck has posted comments on this change.

Change subject: [WIP] add host-cpu to api
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 750: 
Line 751:         #cpu-host support
Line 752:         # see http://wiki.ovirt.org/wiki/Features/Cpu-host_Support
Line 753:         if 'cpuMode' in self.conf:
Line 754:             cpu.setAttribute('mode', self.conf.get('cpuMode'))
Dan, for my own selfish needs I like your offer ;)

But for the sake of future readers, here's some more info;

We need to differ mode from model.

mode is a higher level attribute, which is provided to "make it easier to configure a guest CPU to be as close to host CPU as possible". The default mode is "custom", which means "the cpu element describes the CPU that should be presented to the guest.". 

model, along with the topology, vendor and other attributes will be used to describe the pCPU for the guest OS.

So you actually do not need the latter in passthrough mode, as you can now understand. These modes (custom VS host-passthrough) are actually mutually exclusive.

So for future vdsm needs mode should be added. For my current needs your offer is good enough. Going forward we cannot help but adding cpu mode.
Line 755: 
Line 756:         # This hack is for backward compatibility as the libvirt does not allow
Line 757:         # 'qemu64' guest on intel hardware
Line 758:         if model == 'qemu64' and not '+svm' in features:


--
To view, visit http://gerrit.ovirt.org/9367
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9d107deec2f00912878161348ba639eaa6c4f07
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list