Change in vdsm[master]: fix error handling for misc.NoIntrPoll

danken at redhat.com danken at redhat.com
Mon Nov 26 15:16:44 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: fix error handling for misc.NoIntrPoll
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

sorry for not being clear earlier: the important thing about having CONSTANTS, is that other intervals are calculated based on them. Now, if I decide make the test even shorter, I still have to change it in two places.

....................................................
File tests/miscTests.py
Line 1132:         intrThread = threading.Thread(target=fakeSigchld)
Line 1133:         intrThread.setDaemon(True)
Line 1134:         intrThread.start()
Line 1135: 
Line 1136:         pollIntervalMsec = 1000
for me, the important thing would be to have

 RETRIES = 3  #the arg to range()
 pollIntervalMsec = 1000 * sleepTime * 2 * RETRIES
 

(and it's nicer to have ALLCAPS for constants)
Line 1137:         tempFd, tempPath = tempfile.mkstemp()
Line 1138: 
Line 1139:         poller = select.poll()
Line 1140:         poller.register(tempFd, select.POLLERR)


--
To view, visit http://gerrit.ovirt.org/9458
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I272654a9006fdab77e5fab608ac287416d75843e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list