Change in vdsm[master]: miscTests: using MACRO instead of string

danken at redhat.com danken at redhat.com
Mon Nov 26 15:11:06 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: miscTests: using MACRO instead of string
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

only a minor comment.

....................................................
File tests/miscTests.py
Line 38: EXT_ECHO = "echo"
Line 39: EXT_SLEEP = "sleep"
Line 40: EXT_PYTHON = "python"
Line 41: EXT_WHOAMI = "whoami"
Line 42: EXT_CAT = "cat"
how about keeping this list sorted?
Line 43: SUDO_USER = "root"
Line 44: SUDO_GROUP = "root"
Line 45: 
Line 46: 


--
To view, visit http://gerrit.ovirt.org/9465
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I005dee7f14e239c36cf1d8e6632406991e410ac5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list