Change in vdsm[master]: Fix return value of shutdown() on failure

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Mon Nov 26 09:58:22 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Fix return value of shutdown() on failure
......................................................................


Patch Set 1:

If I read it correct in the old situation it will log the error and then fall through to the normal return telling the engine it worked (unless doneCode['code'] contains the error code). This is changed to an explicit error message, but it didn't return None.

--
To view, visit http://gerrit.ovirt.org/5434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice01a8db664c8c1a3ca32c15de4865f362e7210e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list