Change in vdsm[master]: Add a flag to libvirtvm's status to report watchdog event

dfediuck at redhat.com dfediuck at redhat.com
Mon Nov 26 09:48:19 UTC 2012


Doron Fediuck has posted comments on this change.

Change subject: Add a flag to libvirtvm's status to report watchdog event
......................................................................


Patch Set 2: (1 inline comment)

....................................................
Commit Message
Line 7: Add a flag to libvirtvm's status to report watchdog event
Line 8: 
Line 9: This flag will be set once watchdog event is triggered.
Line 10: And thie flag will be not cleanup after it is set unless the client
Line 11: restart or shutdown VM. So add a timestamp in the message of this flag.
Overwriting is good enough.

I actually had in mind 2 events happening before vdsm was polled, but since this is also being logged I think overwriting is the right thing to do.
Line 12: 
Line 13: The timestamp is the time in seconds since the Epoch.
Line 14: 
Line 15: When the client poll this flag, it should record and check the timestamp


--
To view, visit http://gerrit.ovirt.org/9429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa676299c748d761e216469569156140a79af65
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list