Change in vdsm[master]: fix error handling for misc.NoIntrPoll

danken at redhat.com danken at redhat.com
Mon Nov 26 08:18:04 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: fix error handling for misc.NoIntrPoll
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Thanks for nailing this bug!

....................................................
File tests/miscTests.py
Line 1124: class NoIntrPollTests(TestCaseBase):
Line 1125:     def testNoIntr(self):
Line 1126:         def fakeSigchld():
Line 1127:             for i in range(5):
Line 1128:                 time.sleep(1)
Could you use time CONSTANTS, and make them shorter? I'd hate to spend 10 more seconds...
Line 1129:                 os.kill(os.getpid(), signal.SIGCHLD)
Line 1130: 
Line 1131:         intrThread = threading.Thread(target=fakeSigchld)
Line 1132:         intrThread.setDaemon(True)


....................................................
File vdsm/storage/misc.py
Line 1345: 
Line 1346:     while True:
Line 1347:         try:
Line 1348:             return pollfun(timeout)
Line 1349:         except (os.error, select.error), e:
some of the change is really required since

 os.error is OSError
Line 1350:             if e.args[0] != errno.EINTR:
Line 1351:                 raise
Line 1352:         timeout = max(0, endtime - time.time())
Line 1353: 


--
To view, visit http://gerrit.ovirt.org/9458
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I272654a9006fdab77e5fab608ac287416d75843e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list