Change in vdsm[master]: Fix return value of shutdown() on failure

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Nov 26 07:41:02 UTC 2012


Mark Wu has posted comments on this change.

Change subject: Fix return value of shutdown() on failure
......................................................................


Patch Set 1:

Doron, 
I didn't really hit this bug and just found it from code review.  It returns None if an exception raises shutdown. 
I am not sure how engine will handle this case. Do I need raise an exception intentionally to see what will happen?

--
To view, visit http://gerrit.ovirt.org/5434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice01a8db664c8c1a3ca32c15de4865f362e7210e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Hunt Xu <mhuntxu at gmail.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list