Change in vdsm[master]: libvirtvm: use <interface type='network'>

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Nov 26 06:21:26 UTC 2012


Mark Wu has posted comments on this change.

Change subject: libvirtvm: use <interface type='network'>
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

Another minor suggestion, 
It's better to update the exaplation of network  in @VmInterfaceDevice
# @network:     The name of the attached host bridge device

It could just represent the libvirt network, but not for any host bridge.

....................................................
File vdsm/libvirtvm.py
Line 2794: 
Line 2795:             network = None
Line 2796:             source = x.getElementsByTagName('source')
Line 2797:             if source:
Line 2798:                 network = source[0].getAttribute('bridge')
What's the purpose of this code?  Make sure not to break across vdsm live upgrade?
It's better to add a comment
Line 2799:                 if not network:
Line 2800:                     network = source[0].getAttribute('network')
Line 2801:                     network = network[len(netinfo.LIBVIRT_NET_PREFIX):]
Line 2802: 


--
To view, visit http://gerrit.ovirt.org/9441
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If173a6351b1033c3a1c821cbadd05a2cbdf3d76c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list