Change in vdsm[master]: Add a flag to libvirtvm's status to report watchdog event

dfediuck at redhat.com dfediuck at redhat.com
Sun Nov 25 09:57:51 UTC 2012


Doron Fediuck has posted comments on this change.

Change subject: Add a flag to libvirtvm's status to report watchdog event
......................................................................


Patch Set 2: (3 inline comments)

ShaoHe,
See inline comments / question.

Thanks!

....................................................
Commit Message
Line 6: 
Line 7: Add a flag to libvirtvm's status to report watchdog event
Line 8: 
Line 9: This flag will be set once watchdog event is triggered.
Line 10: And thie flag will be not cleanup after it is set unless the client
thie/the
Line 11: restart or shutdown VM. So add a timestamp in the message of this flag.
Line 12: 
Line 13: The timestamp is the time in seconds since the Epoch.
Line 14: 


Line 7: Add a flag to libvirtvm's status to report watchdog event
Line 8: 
Line 9: This flag will be set once watchdog event is triggered.
Line 10: And thie flag will be not cleanup after it is set unless the client
Line 11: restart or shutdown VM. So add a timestamp in the message of this flag.
What happens if watchdog fires more than once for the same VM before it vdsm was polled?
Line 12: 
Line 13: The timestamp is the time in seconds since the Epoch.
Line 14: 
Line 15: When the client poll this flag, it should record and check the timestamp


....................................................
File vdsm/libvirtvm.py
Line 2227: 
Line 2228:         self.watchdogEvent = {}
Line 2229:         self.watchdogEvent["time"] = time.time()
Line 2230:         self.watchdogEvent["action"] = actionToString(action)
Line 2231:         self.log.debug("Watchdog event comes from guest %s. "
I'd consider putting this as info rather than debug.
Line 2232:                        "Action: %s", self.conf['vmName'],
Line 2233:                        actionToString(action))
Line 2234: 
Line 2235:     def changeCD(self, drivespec):


--
To view, visit http://gerrit.ovirt.org/9429
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7aa676299c748d761e216469569156140a79af65
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list