Change in vdsm[master]: vdsm.spec: Add packages versions for rhel7

danken at redhat.com danken at redhat.com
Sun Nov 25 09:47:25 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm.spec: Add packages versions for rhel7
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)

....................................................
Commit Message
Line 5: CommitDate: 2012-11-24 17:33:04 -0500
Line 6: 
Line 7: vdsm.spec: Add packages versions for rhel7
Line 8: 
Line 9: Add macro for RHEL7 packages.
"macro"?
Line 10: 
Line 11: Change-Id: Ia556789f9a2456f255d822f7e28877168d603f6e


....................................................
File vdsm.spec.in
Line 80: 
Line 81: %if 0%{?rhel}
Line 82: %if 0%{?rhel} >= 7
Line 83: ExclusiveArch:  x86_64
Line 84: Requires: python >= 2.7.3
I should have said this earlier, but how about dropping all the versions from these dependencies? AFAIK, non of them is a real el7 requirement in the sense that el7 would not ship with python < 2.7.3.

While at it, how about sorting the list (in the el7 section)?
Line 85: Requires: qemu-kvm >= 2:1.2.0
Line 86: Requires: qemu-kvm-img >= 2:1.2.0
Line 87: Requires: libvirt >= 0.10.1-1
Line 88: Requires: iscsi-initiator-utils >= 6.2.0.872-14


Line 89: Requires: device-mapper-multipath >= 0.4.9-18
Line 90: Requires: e2fsprogs >= 1.41.14
Line 91: Requires: kernel >= 3.6
Line 92: Requires: sanlock >= 2.4-2, sanlock-python
Line 93: Requires: sed >= 4.2.1-10
when the versions are dropped, "sed" and "kernel" can be dropped as well.
Line 94: Requires: selinux-policy-targeted >= 3.10.0-149
Line 95: Requires: lvm2 >= 2.02.95
Line 96: %else
Line 97: Requires: python


--
To view, visit http://gerrit.ovirt.org/9428
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia556789f9a2456f255d822f7e28877168d603f6e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Shu Ming <shuming at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list