Change in vdsm[master]: Fix warnings at end of tests

smizrahi at redhat.com smizrahi at redhat.com
Thu Nov 22 22:54:25 UTC 2012


Saggi Mizrahi has posted comments on this change.

Change subject: Fix warnings at end of tests
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vdsm/storage/remoteFileHandler.py
Line 240:             os.kill(self.process.pid, signal.SIGKILL)
Line 241:         except:
Line 242:             pass
Line 243: 
Line 244:         if zombieReaper is not None:
I assume it's just the VM shutting down unloading modules out of order.
In any case, it's better then nothing
Line 245:             zombieReaper.autoReapPID(self.process.pid)
Line 246: 
Line 247:     def __del__(self):
Line 248:         self.stop()


--
To view, visit http://gerrit.ovirt.org/9395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id11acbffcbc9faaef54a2ba3b24ed82c8710f51c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list